ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
378 stars 62 forks source link

The UI is falling apart after recent GH updates #270

Closed oleq closed 3 years ago

oleq commented 3 years ago

This happens to the link UI, tables UI, mentions, etc.

1k+ people are using this extension. Maybe there's some easy way to address these issues?

pomek commented 3 years ago

Github Writer uses the !important statement and some variables that may no longer exist in the scope.

image

To fix the issue, we should:

Mgsy commented 3 years ago

Before the changes, GitHub was storing those variables in framework.css. A snapshot of the file containing variables used by GitHub Writer could be found here. It seems that a good place to start will be analyzing a current theme's stylesheet, as there are many variables defined.

fredck commented 3 years ago

stop using !important when aligning the editor's design (CSS) to the Github page.

This is unfortunately not that simple. We don't have control on the building and loading order of some CSS that get into conflict. For example, many of the !important usage is to overcome the CKEditor reset styles themselves.