Ctrl+Enter not working to submit comment

[asherber]

For the last few weeks, Ctrl+Enter has not been working to submit a comment or issue. If I turn GitHub Writer off, then it works correctly, so it seems that the extension might be interfering with this key combination.

[mateuszzagorski]

I am unable to replicate this issue. Can you please check again and if it's still happening provide us with more details?

[asherber]

Sure--what kinds of details would you like?

[asherber]

On a completely clean box where GitHub Writer is the only Chrome extension, I do not see the issue. But on my three work machines, with several extensions, I do see it -- and when I turn off GitHub Writer, the issue goes away. 

It looks like this might be a conflict between GitHub Writer and some other extension. Short of turning off all extensions and then turning them back on one at a time, is there any other information I can give you? 

Here are my current active extensions:

ahfgeienlihckogmohjhadlkjgocpleb : Web Store : version 0_2
apnjnioapinblneaedefcnopcjepgkci : GitHub Repository Size : version 0_6_0
bkhaagjahfmjljalopjnoealnfndnagc : Octotree - GitHub code tree : version 7_5_0
diilnnhpcdjhhkjcbdljaonhmhapadap : GitHub Writer : version 1_9_0
fngmhnnpilhplaeedifhccceomclgfbg : EditThisCookie : version 1_6_3
gfdkimpbcpahaombhbimeihdjnejgicl : Feedback : version 1_0
ghbmnnjooekpmoecnnnilnnbdlolhkhi : Google Docs Offline : version 1_42_0
hoccpcefjcgnabbmojbfoflggkecmpgd : github-vscode-icons : version 1_24
ijfgglilaeakmoilplpcjcgjaoleopfi : MultiLogin : version 1_0_26
kmendfapggjehodndflmmgagdbamhnfd : CryptoTokenExtension : version 0_9_74
lefcpjbffalgdcdgidjdnmabfenecjdf : GitHub Code Folding : version 0_2_0
lhiklbgjcblimmjjflobpncgihagcmbj : GitHub Highlight Selected : version 2_3
lmfdblomdpkcniknaenceeogpgepocmm : RemoveCookiesForSite : version 1_6
mhjfbmdgcfjbbpaeojofohoefgiehjai : Chrome PDF Viewer : version 1
neajdppkdcdipfabeoofebfddakdcjhd : Google Network Speech : version 1_0
njabckikapfpffapmjgojcnbfjonfjfg : cookies.txt : version 1_14_1
nkeimhogjdpnpccoofpliimaahmaaome : Google Hangouts : version 1_3_18
nmmhkkegccagdldgiimedpiccmgmieda : Chrome Web Store Payments : version 1_0_0_6
oeopbcgkkoapgobdbedcemjljbihmemj : Checker Plus for Gmail™ : version 23_0_5

[asherber]

This might be relevant. Sometimes when I pull up a GH page, it looks like GitHub Writer didn't fully load -- edit boxes show Markdown and Preview tabs, instead of Write. When this happens, I do Shift+F5 to force reload everything.

On my clean box, where Ctrl+Enter was just working fine, I hit Shift+F5 and then Ctrl+Enter stopped working.

[mateuszzagorski]

Thank you for all the details you've shared - we will try and take a deeper look into that. I'll post any updates in here.

[mateuszzagorski]

I've installed the extensions based on the information you've provided us with ( apart from the njabckikapfpffapmjgojcnbfjonfjfg : cookies.txt : version 1_14_1 and kmendfapggjehodndflmmgagdbamhnfd : CryptoTokenExtension : version 0_9_74 ), and even with all of those loaded it still does work for me on MacOS.

Could you please share a bit more information:
- Are you on Windows?
- Is it happening only in some particular scenario (e.g. editing comment, creating new issue etc.), or just always?

[asherber]

I am on Windows. Here are specific steps to reproduce.

1. Open Windows Sandbox (clean copy of Windows)
2. Install Chrome
3. Go to a GitHub repo, open an issue
4. Enter comment; Ctrl+Enter works
5. Close GitHub tab
6. Install GitHub Writer
7. Go back to GitHub repo
8. Hmm, GHW doesn't seem to be loaded -- I can see both tabs in the comment area
9. Hit F5; now I see just the single Write tab
10. Enter comment; Ctrl+Enter has no effect

As you can see, this happens on a completely clean version of Windows, completely clean installation of Chrome.

Once it has been triggered, the bug seems to affect all editing boxes.

[mateuszzagorski]

Thank you for all of the information you've shared, I was able to reproduce the issue on Windows, as well as on MacOS (cmd + enter seem to not work as intended as well). We'll try and resolve this issue before the next release.

[asherber]

Bump. Any news on this?

[asherber]

Bump. This, along with #443, unfortunately makes the extension not usable for me.