search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
380 stars 61 forks source link

Fixed long text overlaping commit button #326

Closed mateuszzagorski closed 2 years ago

mateuszzagorski commented 2 years ago

Long text should no longer overlap the 'commit changes area button'. Closes #266.

mlewand commented 2 years ago

Adding overflow auto to what is currently denoted by .github-writer-size-container changed the behavior a little. Note the editors toolbar positioning availability in issues (content is scrolled, toolbar is still visible):

And in case of file editing it's now possible that the editor toolbar will be hidden:

Note that it doesn't happen like that for the native GH editor:

This is actually what we should be looking at. The toolbar should not be hidden in some nested scrolling element.

It's ok for us to have this fix to make it look a little better but we need to report the problem above and give it a proper fix :point_up:

mateuszzagorski commented 2 years ago

I've created an issue for the problem mentioned above here: https://github.com/ckeditor/github-writer/issues/329.