search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
380 stars 61 forks source link

batch-constructor-deprecated-string-type warning logged when typing a mention #331

Closed Reinmar closed 1 year ago

Reinmar commented 2 years ago

:memo: Provide detailed reproduction steps (if any)

  1. Open a page with github-writer editor.
  2. Open dev console.
  3. Start typing a mention in editor, for example @ps.

:heavy_check_mark: Expected result

No warnings in dev console.

:x: Actual result

Warnings in dev console.

image

:question: Possible solution

After quick research i've found that in one place rely the problem: Wordfinder plugin.

Solution is to change 'transparent' into { isUndoable: false }.

:page_with_curl: Other details