search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
379 stars 61 forks source link

GH Writer doesn't load in the review comment textarea #345

Closed Dumluregn closed 1 year ago

Dumluregn commented 2 years ago

📝 Provide detailed reproduction steps (if any)

  1. Open any PR.
  2. Go to Files changed tab.
  3. Click Review changes button.

✔️ Expected result

GH Writer should be loaded in the popping editable.

❌ Actual result

No GH Writer:

❓ Possible solution

AFAICS the selector assigned for the ReviewEditor class (div.pull-request-review-menu > form) is outdated - it doesn't match any element on the site. Probably adjusting it should be enough to solve the issue.

It could be a good idea to ensure that all the other editor types still have proper selectors (probably so as do similar issues are reported, but still).

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

mateuszzagorski commented 1 year ago

Updating the selector does seem to resolve the issue for ReviewEditor not being loaded as per your suggestion.

We should consider applying some tweaks to the styling of it, because now after it's loaded it looks like this:

Normal view:

Markdown view:

Edit: This is happening only on smaller screen sizes.

Dumluregn commented 1 year ago

Since you've said that .pull-request-review-menu class is currently added by Writer, I guess there may also be some custom CSS attached? Then it should be enough to just change the selectors there too.