ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
379 stars 61 forks source link

Native CKE5 tooltips are broken after bumping CKE5 to 35.1.0 #365

Closed mlewand closed 1 year ago

mlewand commented 1 year ago

📝 Provide detailed reproduction steps (if any)

The native CKE5 tooltips doesn't look properly after bumping CKE5 to 35.1.0. Note that it seems to me that buttons in the main toolbar of GH Writer are using customized tooltips.

I noticed this while reviewing #364.

  1. Build GHWriter extension with CKE5 35.1.0.
  2. Insert an image to GHW instance.
  3. Focus the image.
  4. Hover the image alt text button.

✔️ Expected result

It should look consistent, here's how it looked before editor bump:

❌ Actual result

Same thing for table toolbar:

In heading dropdown menu there's the same issue:

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Dumluregn commented 1 year ago

Done in #370.