search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
379 stars 61 forks source link

Batch constructor deprecated string type warning after bumping CKE5 to 35.1.0 #368

Closed pszczesniak closed 1 year ago

pszczesniak commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Execute tests on github-writer version with CKE bumped to 35.1.0 version.
  2. All tests passed but there are some warnings.
  3. Start typing a mention in editor (warnings in browser console)
  4. Duplicated issue #331

✔️ Expected result

All tests pass without any warnings.

❌ Actual result

All tests pass with any warnings.

❓ Possible solution

After quick research i've found that in those two places rely the problem:

  1. Wordfinder plugin.

Solution is to change 'transparent' into { isUndoable: false }.

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

pszczesniak commented 1 year ago

Duplicated off #331.