search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
379 stars 61 forks source link

Inconsistent table/image toolbar #377

Closed Acrophost closed 1 year ago

Acrophost commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Add a bigger image/table
  2. Focus whole added widget to see its toolbar
  3. Scroll down to see the toolbar on the bottom of image/table

✔️ Expected result

Toolbar is white with white triangle.

❌ Actual result

Image/Table toolbar has black triangle, which is inconsistent
 

Screenshot 2022-10-05 at 16 03 46

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Acrophost commented 1 year ago

Since this issue is not only observable on Firefox but also Chrome, I've edited the issue (it's easier observable on FF since the tooltip appears on the bottom of tables and smaller images there from start)

mateuszzagorski commented 1 year ago

As mentioned here -> https://github.com/ckeditor/github-writer/pull/394#issuecomment-1280597675 most of the issues will be resolved out of the box by simply upgrading the editor version.

What's left to address will be resolved with this PR: #400.