search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
379 stars 61 forks source link

Wrong tooltip for markdown switch button #382

Closed mateuszzagorski closed 1 year ago

mateuszzagorski commented 1 year ago

The tooltip for switching to/from markdown mode button, will now have the expected text. Closes #378.

mmotyczynska commented 1 year ago

There is an issue in CSS but it was not introduced in this ticket so we'll discuss it tomorrow if it should be fixed here or in a follow-up ticket. The issue is about the tooltips being blank when GitHub theme other than light/dark is selected (e.g. Sync with system). The color of background is the same as the color of font so the tooltip text is not visible. I think it'd be worth checking other themes as well. 

mmotyczynska commented 1 year ago

I extracted the theme case I described above to a followup issue #390.