search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

Fix CSS for tooltips for GitHub "Sync with system" theme #390

Closed mmotyczynska closed 1 year ago

mmotyczynska commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Switch GitHub theme to Sync with system.
  2. Hover over any button in the toolbar.

✔️ Expected result

The text and background colors are different and you can read its content.

❌ Actual result

The text and background colors are the same and you cannot read its content.

❓ Possible solution

We should add some more CSS selectors for the Sync with system theme. For now we already have selectors for light theme html[data-color-mode="light"] in panel.css file and probably we just have to create a similar ones for html[data-color-mode="auto"].

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

mateuszzagorski commented 1 year ago

After bumping used editor version to 35.2.1 the problem within the main toolbar seems to be fixed.

However it does not fix the behavior for table/image balloon toolbar, and when hovering over the the opened heading dropdown buttons.

mmotyczynska commented 1 year ago

Yes, I can confirm that toolbar tooltips are fixed except for the Heading dropdown items.