ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

Failing tests due to outdated paths #392

Closed mlewand closed 1 year ago

mlewand commented 1 year ago

📝 Provide detailed reproduction steps (if any)

There are some failing after our previous CKE5 bumps.

Running tests with yarn test doesn't work.

✔️ Expected result

Runner should... well, run.

❌ Actual result

$ yarn test
yarn run v1.22.17
$ ckeditor5-dev-tests -sc --files=./tests/unit/**/*.js --coverage-paths=./src
⚠ You're running tests in dev mode - some error protections are loose. Use the `--production` flag to use strictest verification methods.

START:
(...)

ERROR in ./tests/unit/dependencies/ckeditor5-markdown-gfm.js
Module not found: Error: Can't resolve '@ckeditor/ckeditor5-list/src/listediting' in 'C:\Development\htdocs\ckSource\ckeditor5\github-writer\tests\unit\dependencies'

ERROR in ./tests/unit/plugins/autoformat.js
Module not found: Error: Can't resolve '@ckeditor/ckeditor5-list/src/listediting' in 'C:\Development\htdocs\ckSource\ckeditor5\github-writer\tests\unit\plugins'

ERROR in ./tests/unit/dependencies/ckeditor5-markdown-gfm.js
Module not found: Error: Can't resolve '@ckeditor/ckeditor5-list/src/todolistediting' in 'C:\Development\htdocs\ckSource\ckeditor5\github-writer\tests\unit\dependencies'

ERROR in ./tests/unit/plugins/autoformat.js
Module not found: Error: Can't resolve '@ckeditor/ckeditor5-list/src/todolistediting' in 'C:\Development\htdocs\ckSource\ckeditor5\github-writer\tests\unit\plugins'
i 「wdm」: Failed to compile.
11 10 2022 22:02:13.570:INFO [karma-server]: Karma v5.2.3 server started at http://localhost:9876/
11 10 2022 22:02:13.572:INFO [launcher]: Launching browsers CHROME_LOCAL with concurrency unlimited
11 10 2022 22:02:13.652:INFO [launcher]: Starting browser Chrome
Error from chokidar (C:\): Error: EBUSY: resource busy or locked, lstat 'C:\DumpStack.log.tmp'
11 10 2022 22:02:16.126:INFO [Chrome 105.0.0.0 (Windows 10)]: Connected on socket b2UNNqNAj8bGCHkqAAAA with id 31400674
11 10 2022 22:02:18.162:WARN [reporter]: SourceMap position not found for trace: Uncaught Error: Cannot find module '@ckeditor/ckeditor5-list/src/listediting'
at http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:249206:150

Error: Cannot find module '@ckeditor/ckeditor5-list/src/listediting'
    at webpackMissingModule (http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:249206:45)
    at ./tests/unit/dependencies/ckeditor5-markdown-gfm.js (http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:249206:160)
    at __webpack_require__ (http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:20:30)
    at ./build/.automated-tests/entry-point.js (http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:426:161)
    at __webpack_require__ (http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:20:30)
    at http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:84:18
    at http://localhost:9876/base/build/.automated-tests/entry-point.js?3d1dfd52c91dc3cc758f5266364c933d4a18b4ce:87:10
Chrome 105.0.0.0 (Windows 10) ERROR
  Uncaught Error: Cannot find module '@ckeditor/ckeditor5-list/src/listediting'
  at webpack:///tests/unit/dependencies/ckeditor5-markdown-gfm.js:1:1 <- build/.automated-tests/entry-point.js:249206:150

  Error: Cannot find module '@ckeditor/ckeditor5-list/src/listediting'
      at webpackMissingModule (webpack:///tests/unit/dependencies/ckeditor5-markdown-gfm.js:1:1 <- build/.automated-tests/entry-point.js:249206:45)
      at ./tests/unit/dependencies/ckeditor5-markdown-gfm.js (webpack:///tests/unit/dependencies/ckeditor5-markdown-gfm.js:1:1 <- build/.automated-tests/entry-point.js:249206:160)
      at __webpack_require__ (webpack:///webpack/bootstrap:19:1 <- build/.automated-tests/entry-point.js:20:30)
      at ./build/.automated-tests/entry-point.js (webpack:///build/.automated-tests/entry-point.js:1:1 <- build/.automated-tests/entry-point.js:426:161)
      at __webpack_require__ (webpack:///webpack/bootstrap:19:1 <- build/.automated-tests/entry-point.js:20:30)
      at webpack:///webpack/bootstrap:83:1 <- build/.automated-tests/entry-point.js:84:18
      at build/.automated-tests/entry-point.js:87:10

Finished in 2.039 secs / 0 secs @ 22:02:18 GMT+0200 (Central European Summer Time)

❓ Possible solution

Upstream plugins were simply moved. It's a matter of adjusting paths.

📃 Other details


If you'd like to see this fixed sooner, add a 👍 reaction to this post.