search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

Updated CKE5 dev/dependencies to 35.2.1 #397

Closed mateuszzagorski closed 1 year ago

mateuszzagorski commented 1 year ago

Updated package.json file with never version of CKE5 dependencies and devdependencies. Closes #399.

mateuszzagorski commented 1 year ago

Yes I've run the tests, and the only one failing for me is the one from the savedreplies plugin -> should insert the reply on user selection.
I wanted to talk about it and create an issue specifically to resolve it (as I wasn't able to fix it quickly) - since overall the bump does seem to work, and without this PR merged we will delay a bunch of others. 

So if you agree - I will extract the issue regarding test coverage and possibly we can merge this one as it is.

mlewand commented 1 year ago

That's odd. As changelog say, we moved v35.2.0 the bold and paragraph icons to the core package:

If you browse current code, e.g. tests for kabab plugin (permalink) it's using basic-styles package instead of core:

How is that possible, am I missing something?

mlewand commented 1 year ago

I added a commit fixing the icon paths. There's another issue #402 that I won't be able to do as a part of review so I extracted it.