ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

Cannot submit code reviews with version 1.10.1 of the Chrome extension enabled. #448

Open griggi-ws opened 1 year ago

griggi-ws commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Navigate to "Files changed" of a PR
  2. Click "Review changes" and enter data in the comment body
  3. Click "Submit Review"

✔️ Expected result

Review is submitted

❌ Actual result

No effect, and this error appears in console:

An invalid form control with name='pull_request_review[body]' is not focusable. <textarea name="pull_request_review[body]" id="pull_request_review_body" placeholder="Leave a comment" aria-label="Comment body" class="js-comment-field js-paste-markdown js-task-list-field js-quick-submit form-control input-contrast comment-form-textarea js-session-resumable js-saved-reply-shortcut-comment-field" dir="auto" data-github-writer-was-required="false" required></textarea>

❓ Possible solution

This appears to be owing to a very recent change on GitHub's side of things, as I've been using this version of the extension without issue for some time - it's only been in the last two weeks or so that this issue has started.

📃 Other details


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

akosasante commented 1 year ago

Also reported here: https://github.com/ckeditor/github-writer/issues/443

akosasante commented 1 year ago

Looks like it was fixed 🎉 https://github.com/ckeditor/github-writer/pull/449