search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

When trying to upload a file above the size limit (>10MB), a "TypeError: can't convert undefined to object" shows up #454

Open charlttsie opened 1 year ago

charlttsie commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Prepare a file whose size is larger than 10MB
  2. With GitHub writer enabled, try to upload the file

✔️ Expected result

A message about exceeding the size limit appears

❌ Actual result

A TypeError: can't convert undefined to object alert message shows up

large-file (1)

❓ Possible solution

The UX could be improved and a more informative message should be provided. Here's, for example, how it looks without the extension:

big-file-alert

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

dufipl commented 1 year ago

The same thing happens when an unsupported image format is being uploaded.