ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

Refreshing the page during uploading an image causes it to load infinitely #457

Open michalbilik opened 1 year ago

michalbilik commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Upload an image.
  2. Refresh the page during uploading.

✔️ Expected result

What is the expected result of the above steps?

After the refresh it should be indicated that the upload it was not successful.

For the built in GitHub, after the refresh session resume feature just shows shows the image as a link to the issue, and user can add comment. 

https://github.com/ckeditor/github-writer/assets/50703222/219e16fb-7cc4-4783-880e-5d5c472b56fb

❌ Actual result

What is the actual result of the above steps?

The image is "uploading" infinitely, and the comment cannot be added until the link is deleted.

https://github.com/ckeditor/github-writer/assets/50703222/ae4e130f-4bd7-4b1b-9063-e66ee251af47

📃 Other details

This is an edge case scenario.

Related to these issues:


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Rishav01 commented 5 months ago

Hi,

It may sound very much weird but I was working intensively on a single file for last 8 hours. Making some notes actually about tech. I accidently pressed some button. It did not asked me anything like discard changes or something. But I later realized that what I did. I tried to press back button and I can see that the editor is empty. Its 5:22 AM Ist and I was working since last evening yesterday. Is it anything I try possibly to get my data back? Thanks in advance