ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
378 stars 62 forks source link

Does not work on Wiki pages #461

Open mwisnicki opened 1 year ago

mwisnicki commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Install extension in Chrome
  2. Create new wiki page on any repo

✔️ Expected result

Extension works like on issue pages

❌ Actual result

Nothing changed

📃 Other details


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Mark-LaCroix commented 1 year ago

For me, it's not that it doesn't work on Wiki pages, it's that it hides the input area completely (see below image), so it makes wiki pages completely uneditable, and this lovely, much needed extension unusable for me, sadly.

Perhaps some CSS id/class names recently changed on Wiki pages but not on Issue pages?

Browser: Firefox 115.0.2
OS: Windows 11
 

image

CodeSmile-0000011110110111 commented 1 year ago

I get this "missing editor" issue too in both Firefox and Chrome, but only randomly. Most of the time it's just the plain markdown editor.

The browser console in Firefox only prints this repeatedly when the editor is missing:

Unable to find target with innerWindowId:6442450947 [watcher.js:188:13](resource://devtools/client/fronts/watcher.js)
    getWindowGlobalTargetByInnerWindowId resource://devtools/client/fronts/watcher.js:188
    _getTargetForWatcherResource resource://devtools/shared/commands/resource/resource-command.js:905
    _onResourceAvailable resource://devtools/shared/commands/resource/resource-command.js:643
    _emit resource://devtools/shared/event-emitter.js:242
    emit resource://devtools/shared/event-emitter.js:186
    emit resource://devtools/shared/event-emitter.js:330
    onPacket resource://devtools/shared/protocol/Front.js:349
    onPacket resource://devtools/client/devtools-client.js:471
    send resource://devtools/shared/transport/local-transport.js:67
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103