search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
376 stars 61 forks source link

Broken appearance #480

Closed Comandeer closed 2 months ago

Comandeer commented 3 months ago

📝 Provide detailed reproduction steps (if any)

  1. Open any GitHub issue and scroll to the comment editor.

✔️ Expected result

GitHub writer has a readable, visible UI.

❌ Actual result

UI is nearly invisible and the additional toolbar does not have any background. The issue is more prominent in any of the GH dark themes: Screenshot 2024-04-03 at 12 46 18

❓ Possible solution

Probably styles for GH Writer should be updated.

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

illia-stv commented 3 months ago

I noticed in light theme it's also doesn't look very nice in my opinion, are we okay with that transparent background?

What do you think about inheriting background (not transparent) like this?
 

Witoso commented 3 months ago

Yes, this is the same issue. If inherit solves it, we are good to go. The question is about icon colors, I cannot check it how it worked in previous version, but I'm almost 100% sure that the colors were reversed to white in dark theme. Also check the balloons in the editor.