search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
378 stars 62 forks source link

Cannot open a link used in the editor content #92

Open Reinmar opened 4 years ago

Reinmar commented 4 years ago

The link balloon is gone.

fredck commented 4 years ago

The link balloon is gone.

The fact is that we don't have really a link there. It's actually plain text, which is styled as a link by the auto-linking feature, just like for people mentions or issue numbers.

I agree that this can be somehow enhanced. As a minor step, I've opened #62, which would be a nice addition for auto-linked urls, mentions, issues, etc.

One possible additional enhancement is reusing the link ballon on auto-linked urls. We could hide the "edit" option in the ballon and, to make it simpler, no option to remove the link as well (which could be a future enhancement).

WDYT?

fredck commented 4 years ago

FYI, a new features has been introduced, closing #62. This partially solves the issue reported here.

Reinmar commented 4 years ago

One possible additional enhancement is reusing the link ballon on auto-linked urls. We could hide the "edit" option in the ballon and, to make it simpler, no option to remove the link as well (which could be a future enhancement).

That's what I was expecting as CKE5 user. But I don't know what other people will be expecting. I don't think cmd+click will have high enough discoverability, so some kind of balloon seems a must. I don't think that it needs to be the link balloon, though, unless it's easy to reuse it. Implementing a new balloon may be a simpler option.

CKEditorBot commented 1 year ago

There has been no activity in this issue for the last three years. Now it is marked as stale and will be closed in 30 days. We know it may be valid, so if you're interested in the solution, leave a comment or reaction.

CKEditorBot commented 1 year ago

We have closed the issue because of the lack of activity for the last three years. We know it might be valid, so you can open a similar issue if needed.