search

ckelly / django-resume

Django app for presenting and editing a resume
MIT License
24 stars 10 forks source link

Pull request for django-resume #3

Closed aless80 closed 6 years ago

aless80 commented 6 years ago

Hello, this is a pull request for your project. It was a good starting point for me to learn Django, but I had to rebuild it for modern Django (1.10.8) and python 3.5.2. Thanks

ckelly commented 6 years ago

hi @aless80!

Apologies for the delay, and thanks for the PR! Code looks pretty good!

quick question for you - any reason you changed the directory structure? Just curious more than anything.

aless80 commented 6 years ago

Hi @ckelly , About the file structure I had the same question when I started hacking your project. When I decided to rebuild the project from scratch with standard commands I got the structure that you see in my version. Maybe you did the same in an old version of Django and things have changed. I am p-sure my structure reflects the recommended layout. For example, this links (and others) confirms that layouts for Django projects are basically: /myproj/ /myproj/manage.py /myproj/myproj/ /myproj/app1/ /myproj/app2/*

bittner commented 6 years ago

@aless80 I think you have to restore the original README for this PR to get accepted.

aless80 commented 6 years ago

@bittner You mean I cannot edit the original README?

ckelly commented 6 years ago

hey @bittner @aless80

apologies, I was working on getting some things verified, but it all escaped me again. heh.

per previous discussion, I think the original idea was to have sub dirs to allow for testing, etc, but I don't think it's worth going back and reorganizing at this time.

I'm going to approve and merge this, and I'll probably tweak a few things along the way (updated readme, contributors file, etc).

@aless80 I'm also going to give you commit access to the repo, seeing as you did a ton of work here!