cki-project / sktm

"Sonic Kernel Testing Manager" - a job scheduler for skt
GNU General Public License v2.0
0 stars 6 forks source link

Handle Jenkins errors #107

Closed spbnick closed 6 years ago

spbnick commented 6 years ago

This adds detection of test errors (infrastructure failures) and makes sktm ignore Jenkins builds which have them, so that baseline is not degraded and patches are held in pendingpatches, both to be rechecked on subsequent runs.

spbnick commented 6 years ago

This is not tested yet, WIP.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 376


Changes Missing Coverage Covered Lines Changed/Added Lines %
sktm/jenkins.py 0 8 0.0%
sktm/init.py 1 10 10.0%
<!-- Total: 1 18 5.56% -->
Totals Coverage Status
Change from base Build 373: 0.3%
Covered Lines: 318
Relevant Lines: 922

💛 - Coveralls
veruu commented 6 years ago

While I didn't test it either and just checked the code, most of this is removal of unused code and cleanups and should be good to go :+1: the Jenkins part should be properly tested though

spbnick commented 6 years ago

I tested this mostly, still waiting for one job to finish, then we can merge this, and I'll deliver this to staging, along with the required pipeline changes.

spbnick commented 6 years ago

OK, tested with the new pipeline, success and infrastructure failure (cancelled Beaker jobs), baseline and patchwork commands worked fine. @veruu, do you think this is ready to go in?

veruu commented 6 years ago

I think so. And if there is something that breaks in a way we didn't expect we can fix it afterwards.

spbnick commented 6 years ago

Thank you, Veronika :)