Closed idorax closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
sktm/executable.py | 1 | 5 | 20.0% | ||
sktm/jenkins.py | 3 | 33 | 9.09% | ||
<!-- | Total: | 4 | 38 | 10.53% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
sktm/executable.py | 1 | 16.13% | ||
sktm/jenkins.py | 1 | 12.06% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 399: | -0.7% |
Covered Lines: | 465 |
Relevant Lines: | 1122 |
Hi Vector! If you get to the final version of the pull, can you please squash the commits into a single one and let us know so we can check it?
Hi Veronika, the commits are squashed, please check it, thanks!
Veronika, I have updated the related .py files to support a command line option, please check again, thanks!
Thanks Veronika for your review, I have updated the related files according to your comments, please take a look again.
Reopen the PR after updating load_config().
Veronika, I updated the related files according to your comments, please take a look again. Your comments are much appreciated!
Thanks Veronika for review again, I have updated the rest of server.get_job and job.get_build calls to use __get_job()/__get_build(). And I'm not sure job.get_last_build() / job.get_next_build_number() should be enhanced to avoid random networking failures, so just leave them as they are. If you have more concerns/comments, please let me know, thank you very much.
Thanks Veronika again. Okay, I'll implement them this week and file another PR for review.
Since self.jk.is_build_complete() throws an exception when jenkins cannot be reached, we try to use 'try ... except ...' in is_build_complete() to avoid exceptions.