cki-project / sktm

"Sonic Kernel Testing Manager" - a job scheduler for skt
GNU General Public License v2.0
0 stars 6 forks source link

sktm should make multiple attempts to query Jenkins (cont) #119

Closed idorax closed 6 years ago

idorax commented 6 years ago

More functions to have multiple attempts to query Jenkins are added, e.g. o get_build_ids() o get_last_build() o get_next_build_number() o __build_job() o get_base_server_url() Please help to review, thanks.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 417


Changes Missing Coverage Covered Lines Changed/Added Lines %
sktm/jenkins.py 5 24 20.83%
<!-- Total: 5 24 20.83% -->
Totals Coverage Status
Change from base Build 407: -0.2%
Covered Lines: 468
Relevant Lines: 1138

💛 - Coveralls
idorax commented 6 years ago

Veronika, I updated the code to use return getattr(job, method)() now. And these functions in the following are removed, o get_next_build_number() o __build_job() o get_base_server_url() that is, only find_build() is updated in this commit. Please take a look again, thanks!

idorax commented 6 years ago

Veronika, I have updated file jenkins.py according to your comments, please review again, thanks.

idorax commented 6 years ago

Veronika, __get_job_prop() is updated, please review again, thanks!