Closed danghai closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
sktm/executable.py | 0 | 21 | 0.0% | ||
<!-- | Total: | 0 | 21 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
sktm/executable.py | 3 | 16.13% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 407: | 0.04% |
Covered Lines: | 465 |
Relevant Lines: | 1122 |
Thanks Hai. Can you explain (also in the commit message) how stretching a mostly single line of code into 4-6 improves formatting? I'd understand if you changed only ones that don't fit, to see the parameters clearly, but I don't get the reason behind changing the single lines.
@veruu I think making them the same format is good. It is clear, and more readabe. It looks the same as skt
. I do the same this pull: https://github.com/RH-FMK/skt/pull/139/files
The point of the skt pull you linked was to unite the subparsers (which is not needed in sktm), and the format change was a side effect that was questionable. The consistency argument made sense in skt because most of the parameters didn't fit the single line but that's not applicable here. Don't fix what's not broken ;)
@veruu ah okay. So I close this PR now
I make PR to improve argparse formatting.