Open spbnick opened 6 years ago
Also, rename the classes to make more sense. E.g. Patchwork
for the base class, PatchworkXMLRPC
for XML RPC interface, and PatchworkREST
for the REST API.
Note to self: get_patch_by_id
for PW2 raises an exception when it can't get the data needed, while PW1just logs that it couldn't get the data and returns None
. We should throw the exception in both cases, and this would also allow us to remove the checks for no patch returned elsewhere.
The sktm/patchwork.py needs refactoring as it's hard to understand, use and maintain. Some ideas include:
More ideas are welcome!