search

ckipp01 / mill-ci-release

A Mill plugin to help making publishing to Sonatype from GitHub Actions easier.
Apache License 2.0
14 stars 6 forks source link

Support Mill 0.11.0-M1 #36

Closed lolgab closed 1 year ago

lolgab commented 1 year ago

I used a snapshot release of de.tobiasroeser.mill.vcs.version, you may want to wait for the next stable.

ckipp01 commented 1 year ago

I used a snapshot release of de.tobiasroeser.mill.vcs.version, you may want to wait for the next stable.

Hey! Thanks for the pr! Ideally I'd like to include a stable release if I was going to release, but I'm also comfortable merging this, which will produce a snapshot that you could use. Would that work for you? As I'm assuming you're wanting to use this with something that is using 0.11.0-M1 😆

lolgab commented 1 year ago

I'm not waiting on it, so no worries :) We can expect @lefou to publish a stable version soon :) I went through all my plugins to prepare them for 0.11 Also I want to use the performance improvements I added to zinc in my own builds as soon as possible so I created this PR :)

lefou commented 1 year ago

We can expect @lefou to publish a stable version soon :)

Not so sure about that. We have a not so small backlog and we should try to bring as much as possible into 0.11, to avoid a shortly following yet incompatible 0.12. Beside some speed improvements in 0.11, Mill 0.10 is pretty much recent.

I try to publish a new 0.11 milestone whenever the API changes, so that whoever needs to stay on the bleeding edge, has at least an option to target the binary platform.

lolgab commented 1 year ago

We can expect @lefou to publish a stable version soon :)

Not so sure about that. We have a not so small backlog and we should try to bring as much as possible into 0.11, to avoid a shortly following yet incompatible 0.12. Beside some speed improvements in 0.11, Mill 0.10 is pretty much recent.

I try to publish a new 0.11 milestone whenever the API changes, so that whoever needs to stay on the bleeding edge, has at least an option to target the binary platform.

I was referring to a stable version of mill.vcs.version for Mill 0.11.0-M1, not a stable version of Mill :)

lefou commented 1 year ago

I was referring to a stable version of mill.vcs.version for Mill 0.11.0-M1, not a stable version of Mill :)

Oh. 😳 I already published a snapshot supporting Mill 0.11.0-M1: https://repo1.maven.org/maven2/de/tototec/de.tobiasroeser.mill.vcs.version_mill0.11.0-M1_2.13/0.3.0-7-8f12c7/

That's the one already used in this PR. I didn't plan to make a numbered release of it, as it is already accessible from Maven Central. Do you need one?

lolgab commented 1 year ago

If we think it's ok for this plugin to depend on a snapshot release of it, it's fine for me :)

ckipp01 commented 1 year ago

I guess I have opinionated thoughts about snapshots. Mainly if we're ok releasing and having others depend on them, why not just make it a stable release? I can merge this, but my snapshot will go into sonatype snapshots, which means you'd need to add another resolver and doing that for plugins is a bit of a hassles since you have to add a @ up top.

I typically like to avoid relying on SNAPSHOTs for stable releases, but I see there is hardly anything that's changed in the commits up until this, and I know @lefou takes compatibility seriously 😆 .

lefou commented 1 year ago

So, technically, mill-vcs-version-0.3.0-7-8f12c7 is a proper release. It's on Maven Central releases repository, and as such rather immutable. The version is also unique. The only thing that's different from other "official" releases is, that it is not tagged with a git tag and it has no dedicated changelog entry. But it already has the (start of the) commit hash in it's name, so it should be still reproducible.

So it depends where @ckipp01 cut the line between "snapshots" and "releases". Is it semantically (Maintainer created a tag) or technically (the (probably not unique) location of the binary artifact)?

Because of no other changes beside some library dependency bumps, I find a new release kind of overkill. If it would be technically easier, I would in fact try to release the already released version 0.3.0 against the new Mill API, but it's simply not worth the efforts to do it, given the fact, that there will be more of these -Mx Mill releases.

ckipp01 commented 1 year ago

No worries at all. I just released 0.1.5 @lolgab, so you should be able to use that.

Thinking about it, maybe both of us should have used an RC release ha.