search

ckirkendall / kioo

Enlive/Enfocus style templating for Facebook's React and Om in ClojureScript.
Eclipse Public License 1.0
404 stars 39 forks source link

Updated dependencies and tests #66

Closed alesya-h closed 8 years ago

alesya-h commented 8 years ago

This updates Reagent, Om and ClojureScript to latest versions. As part of move to latest ClojureScript, cljx was dropped in favor of cljc files. Also https://github.com/cemerick/clojurescript.test have been deprecated, so it is replaced with native cljs.test and doo (as suggested in deprecation notice). PhantomJS shim have been dropped, as tests work just fine without it in current version of phantomjs (2.0.0). You may wish to release this update as major version.

ckirkendall commented 8 years ago

You are awesome! I will try to get this merged this weekend. I may switch some other things over to using doo. The setup looks a lot cleaner.

ckirkendall commented 8 years ago

I love this change request but unfortunately it breaks those using clojure 1.6 and below. There are lots of people using kioo that can't upgrade at this time so I want to hold off on this.

alesya-h commented 8 years ago

For how long do you plan to postpone? What's wrong with releasing a major version, so those who can't upgrade won't upgrade?

alesya-h commented 8 years ago

And without releasing upgraded version, it holds off people like me who wish to keep their deps up to date. Some of our external components require React 13, which is supported only by Reagent 0.5.0. That's basically why I did all this upgrade. And reagent team is already workinng on adding support for React 14. There will always be people who use outdated versions. But unlike people who need new versions, they are able to just keep using the version they use now.

ckirkendall commented 8 years ago

I think you are right about doing a major release for 1.7. I need to work out some logistics on our branching but I think we can make this happen. On Oct 16, 2015 4:37 PM, "Ales Guzik" notifications@github.com wrote:

And without releasing upgraded version, it holds off people like me who wish to keep their deps up to date. Some of our external components require React 13, which is supported only by Reagent 0.5.0. That's basically why I did all this upgrade. And reagent team is already workinng on adding support for React 14. There will always be people who use outdated versions. But unlike people who need new versions, they are able to just keep using the version they use now.

— Reply to this email directly or view it on GitHub https://github.com/ckirkendall/kioo/pull/66#issuecomment-148827718.

alesya-h commented 8 years ago

It's been almost 2 months since this was submitted :snail:

alesya-h commented 8 years ago

I will try to get this merged this weekend.

I've submitted this 3 months ago. Since then reagent 0.6.0-alpha have been released with support for React 14, but kioo doesn't have support even for React 13, which puts this library obsolete, even though it is a cool library. Do you have plans to maintain this project at all? If you don't and if it works for you I would gladly take over maintaining kioo.

alesya-h commented 8 years ago

And also RC5 for Clojure 1.8.0 have been released, so mainaining support for 1.6 now makes as much sense as maintaining support for 1.0. If someone is stuck with 1.6 then he'd just use older kioo version.

ckirkendall commented 8 years ago

This has been merged now the 1.8 has been released.