search

ckirkendall / kioo

Enlive/Enfocus style templating for Facebook's React and Om in ClojureScript.
Eclipse Public License 1.0
404 stars 39 forks source link

Unsupported style properties #69

Closed stoeckley closed 8 years ago

stoeckley commented 8 years ago

I am trying this library to put a bunch of verbose third-party HTML content into Om components. For the most part it is working well, but some of the HTML appears to use explicit style settings and other things that perhaps kioo is not supporting:

screen shot 2015-11-09 at 11 12 31 am

These errors appear when using the kioo template on this third-party HTML. Do you have advice?

ckirkendall commented 8 years ago

This is caused by how react handles attributes. We do some correction of this in kioo and probably can handle these cases. I will take a look this week at a more comprehensive solution. On Nov 9, 2015 5:15 AM, "astoeckley" notifications@github.com wrote:

I am trying this library to put a bunch of verbose third-party HTML content into Om components. For the most part it is working well, but some of the HTML appears to use explicit style settings and other things that perhaps kioo is not supporting:

[image: screen shot 2015-11-09 at 11 12 31 am] https://cloud.githubusercontent.com/assets/4611759/11031211/1bcddca8-86d3-11e5-9f78-8eac92d4b48e.png

These errors appear when using the kioo template on this third-party HTML. Do you have advice?

— Reply to this email directly or view it on GitHub https://github.com/ckirkendall/kioo/issues/69.

stoeckley commented 8 years ago

Cool, thanks.

Btw this is a great library, has already saved me tremendous time.

ckirkendall commented 8 years ago

This is fixed in master. Sorry it took so long.