search

ckirkendall / kioo

Enlive/Enfocus style templating for Facebook's React and Om in ClojureScript.
Eclipse Public License 1.0
404 stars 39 forks source link

Fix for "React-16: Supported Version" #76

Closed jocrau closed 2 months ago

jocrau commented 6 years ago

I have changed the code so that instead of React.CreateClass() and React.DOM.* it uses the drop in replacements create-react-class and react-dom-factories.

I also had to update the unit tests and change the execution engine to chrome-headless instead of phantom (which throws an exception for ECMAScript 6 code).

The cljsjs dependencies are only included for the externs. not sure if we need them since I added :infer-externs true.

Resolves #75

jocrau commented 6 years ago

@ckirkendall , have you had a chance to look at the code?

metasoarous commented 5 years ago

Hi @ckirkendall.

First off, thanks for this great project.

Would you please take a look at this PR? I'd like to upgrade the React dependency on a project I'm working on, but can't until this is resolved.

Thanks again.

rastandy commented 4 years ago

I would love to use kioo today and this fix would solve this issue I'm encountering in my project. i used Kioo some years ago and loved it so much!