ckirkendall / kioo

Enlive/Enfocus style templating for Facebook's React and Om in ClojureScript.
Eclipse Public License 1.0
404 stars 39 forks source link

Parsing Error with HTML comments #8

Closed sritchie closed 10 years ago

sritchie commented 10 years ago

Okay, moving forward with the project! We found a case that gives a NPE:

    <div id="timer" class="row">
    </div> <!-- / timer -->

I'm not sure which layer this affects, so reporting it here.

Here's the stacktrace:

aused by: java.lang.NullPointerException
    at clojure.core$name.invoke(core.clj:1505)
    at kioo.om$get_om_sym.invoke(om.clj:12)
    at kioo.om$emit_node.invoke(om.clj:24)
    at kioo.core$compile_node.invoke(core.clj:110)
    at kioo.core$compile$fn__47513.invoke(core.clj:117)
    at clojure.core$map$fn__4207.invoke(core.clj:2485)
    at clojure.lang.LazySeq.sval(LazySeq.java:42)
    at clojure.lang.LazySeq.seq(LazySeq.java:60)
    at clojure.lang.RT.seq(RT.java:484)
    at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31)
    at clojure.core$vec.invoke(core.clj:354)
    at kioo.core$compile.invoke(core.clj:117)
    at kioo.core$compile_node.invoke(core.clj:106)
    at kioo.core$compile$fn__47513.invoke(core.clj:117)
    at clojure.core$map$fn__4207.invoke(core.clj:2485)
    at clojure.lang.LazySeq.sval(LazySeq.java:42)
    at clojure.lang.LazySeq.seq(LazySeq.java:60)
    at clojure.lang.RT.seq(RT.java:484)
    at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31)
    at clojure.core$vec.invoke(core.clj:354)
    at kioo.core$compile.invoke(core.clj:117)
    at kioo.core$compile_node.invoke(core.clj:106)
    at kioo.core$compile$fn__47513.invoke(core.clj:117)
    at clojure.core$map$fn__4207.invoke(core.clj:2485)
    at clojure.lang.LazySeq.sval(LazySeq.java:42)
    at clojure.lang.LazySeq.seq(LazySeq.java:60)
    at clojure.lang.RT.seq(RT.java:484)
    at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31)
    at clojure.core$vec.invoke(core.clj:354)
    at kioo.core$compile.invoke(core.clj:117)
    at kioo.core$component_STAR_.invoke(core.clj:97)
    at kioo.om$component.doInvoke(om.clj:40)
    at clojure.lang.RestFn.applyTo(RestFn.java:146)
    at clojure.lang.AFunction$1.doInvoke(AFunction.java:29)
    at clojure.lang.RestFn.applyTo(RestFn.java:137)
    at clojure.core$apply.invoke(core.clj:621)
    at cljs.analyzer$macroexpand_1.invoke(analyzer.clj:1376)
    at cljs.analyzer$analyze_seq.invoke(analyzer.clj:1412)
    at cljs.analyzer$analyze$fn__3162.invoke(analyzer.clj:1505)
    at cljs.analyzer$analyze.invoke(analyzer.clj:1498)
    ... 76 more
ckirkendall commented 10 years ago

I am putting the bet on the comment. I think I see the issue.

On Wed, Feb 5, 2014 at 2:31 PM, Sam Ritchie notifications@github.comwrote:

Okay, moving forward with the project! We found a case that gives a NPE:

<div id="timer" class="row">
</div> <!-- / timer -->

I'm not sure which layer this affects, so reporting it here.

Here's the stacktrace:

aused by: java.lang.NullPointerException at clojure.core$name.invoke(core.clj:1505) at kioo.om$get_om_sym.invoke(om.clj:12) at kioo.om$emit_node.invoke(om.clj:24) at kioo.core$compile_node.invoke(core.clj:110) at kioo.core$compile$fn47513.invoke(core.clj:117) at clojure.core$map$fn4207.invoke(core.clj:2485) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:484) at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31) at clojure.core$vec.invoke(core.clj:354) at kioo.core$compile.invoke(core.clj:117) at kioo.core$compile_node.invoke(core.clj:106) at kioo.core$compile$fn47513.invoke(core.clj:117) at clojure.core$map$fn4207.invoke(core.clj:2485) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:484) at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31) at clojure.core$vec.invoke(core.clj:354) at kioo.core$compile.invoke(core.clj:117) at kioo.core$compile_node.invoke(core.clj:106) at kioo.core$compile$fn47513.invoke(core.clj:117) at clojure.core$map$fn4207.invoke(core.clj:2485) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:484) at clojure.lang.LazilyPersistentVector.create(LazilyPersistentVector.java:31) at clojure.core$vec.invoke(core.clj:354) at kioo.core$compile.invoke(core.clj:117) at kioo.core$componentSTAR.invoke(core.clj:97) at kioo.om$component.doInvoke(om.clj:40) at clojure.lang.RestFn.applyTo(RestFn.java:146) at clojure.lang.AFunction$1.doInvoke(AFunction.java:29) at clojure.lang.RestFn.applyTo(RestFn.java:137) at clojure.core$apply.invoke(core.clj:621) at cljs.analyzer$macroexpand_1.invoke(analyzer.clj:1376) at cljs.analyzer$analyze_seq.invoke(analyzer.clj:1412) at cljs.analyzer$analyze$fn__3162.invoke(analyzer.clj:1505) at cljs.analyzer$analyze.invoke(analyzer.clj:1498) ... 76 more

Reply to this email directly or view it on GitHubhttps://github.com/ckirkendall/kioo/issues/8 .

sritchie commented 10 years ago

Ah, whoops, forgot to add that to my description. It's definitely the comment. (We played with moving it to different lines, adjusting the inner content, etc... removing it fixed the issue.)

ckirkendall commented 10 years ago

I think its an easy fix. I will take a look at getting something out tonight.