ckkelvinchan / RealBasicVSR

Official repository of "Investigating Tradeoffs in Real-World Video Super-Resolution"
Apache License 2.0
906 stars 136 forks source link

Missing file (crop_sub_images.py). #14

Closed sunlustar closed 2 years ago

sunlustar commented 2 years ago

Thanks for your great work, but it seems to lack a related file (crop_sub_images.py) in this project for training. Could you upload this file? I would appreciate it.

ckkelvinchan commented 2 years ago

Sorry about that. I just added it.

sunlustar commented 2 years ago

Thanks. But I have another problem when using distributed training.

image

And I have checked my data path, it is ├─ REDS ├── train_sharp_sub ├───-000_s001 ├───-000_s002

And when I use the single GPU training strategy, there is another problem like, image It seems due to the dismatched batchsize dismension question between input and label, but I don't know why. The parameters in realbasicvsr_wogan_c64b20_2x30x8_lr1e-4_300k_reds.py keep same.

ckkelvinchan commented 2 years ago

If the training dataset path is correct, it seems that the validation set path is incorrect. Have you downloaded the UDM10 dataset for validation?

sunlustar commented 2 years ago

Yes, you are right, I got a mistake with the validation set path. However, it turned to the dismatched batchsize dismension question when using both distributed training and single GPU training, have you ever meet this problem? Thanks. image

ckkelvinchan commented 2 years ago

I did not encounter this error before.

I have no access to the GPU server at the moment. I will run again when I get back the access later today. For now, you can try printing out the input and output dimensions to check if there are any problems.

sunyclj commented 2 years ago

@sunlustar Where was the UDM10 dataset downloaded? train_sharp_sub dataset is which of REDS? thanks. I don't find. 1641885447930_6C7A586C-CFC5-4e1b-BDCF-883B5C106EA3

sunyclj commented 2 years ago

thanks.but i don't have account.i don't download it from here.

---Original--- From: @.> Date: Tue, Jan 11, 2022 15:29 PM To: @.>; Cc: @.**@.>; Subject: Re: [ckkelvinchan/RealBasicVSR] Missing file (crop_sub_images.py).(Issue #14)

@sunyclj You can download udm10 dataset here, https://www.terabox.com/web/share/link?surl=LMuQCVntRegfZSxn7s3hXw&path=%2Fproject%2Fpfnl

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>

Ha0Tang commented 2 years ago

@ckkelvinchan @sunlustar I also meet the error "ValueError: You may use too small dataset and our distributed sampler cannot pad your dataset correctly. We highly recommend you to use fewer GPUs to finish your work". How should I fix it?

Ha0Tang commented 2 years ago

And I have checked my data path, it is ├─ REDS ├── train_sharp_sub ├───-000_s001 ├───-000_s002 ├─ UDM10 ├───-BIx4 ├───---calendar ├───---city ├───---foliage ├───---walk ├───-GT ├───---calendar ├───---city ├───---foliage ├───---walk ├─ VideoLQ

am I missing something? @ckkelvinchan @sunlustar

ckkelvinchan commented 2 years ago

And I have checked my data path, it is ├─ REDS ├── train_sharp_sub ├───-000_s001 ├───-000_s002 ├─ UDM10 ├───-BIx4 ├───---calendar ├───---city ├───---foliage ├───---walk ├───-GT ├───---calendar ├───---city ├───---foliage ├───---walk ├─ VideoLQ

am I missing something? @ckkelvinchan @sunlustar

It seems that the folder UDM10 is not downloaded correctly. You are using Vid4.