ckknight / random-js

A mathematically correct random number generator library for JavaScript.
MIT License
603 stars 49 forks source link

Can't build with webpack #37

Closed aesy closed 4 years ago

aesy commented 4 years ago

Hello!

First off, thanks a lot for making this library. It seems to fit my use case perfectly, but I'm having some trouble getting started. I'm using Webpack with babel-loader and @babel/preset-typescript - it's a pretty simple setup, but when trying to build the project with random-js imported I get the following errors:

ERROR in ../node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/duplex.js' in 'node_modules\stream-browserify'
 @ ../node_modules/stream-browserify/index.js 30:16-52
 @ ../node_modules/browserify-sign/browser/index.js
 @ ../node_modules/crypto-browserify/index.js
 @ ../node_modules/random-js/dist/random-js.esm.js

ERROR in ../node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/passthrough.js' in 'node_modules\stream-browserify'
 @ ../node_modules/stream-browserify/index.js 32:21-62
 @ ../node_modules/browserify-sign/browser/index.js
 @ ../node_modules/crypto-browserify/index.js
 @ ../node_modules/random-js/dist/random-js.esm.js

ERROR in ../node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/transform.js' in 'node_modules\stream-browserify'
 @ ../node_modules/stream-browserify/index.js 31:19-58
 @ ../node_modules/browserify-sign/browser/index.js
 @ ../node_modules/crypto-browserify/index.js
 @ ../node_modules/random-js/dist/random-js.esm.js

ERROR in ../node_modules/stream-browserify/index.js
Module not found: Error: Can't resolve 'readable-stream/writable.js' in 'node_modules\stream-browserify'
 @ ../node_modules/stream-browserify/index.js 29:18-56
 @ ../node_modules/browserify-sign/browser/index.js
 @ ../node_modules/crypto-browserify/index.js
 @ ../node_modules/random-js/dist/random-js.esm.js

Do you have have any pointers as to what could be wrong here? What can I do to pinpoint the problem?

I can post my webpack config and tsconfig if it's of interest.

Webpack version: 4.41.6 Node version: 12.16.0

aesy commented 4 years ago

Actually, I was going to set up a repo with a minimal config to showcase it, but I can't reproduce it - it works fine. There's something wrong with my config of this specific project, so I'm closing this issue.