cknadler / marktab-c

Concise, machine readable guitar tabs
MIT License
36 stars 7 forks source link

Remove transitions involving sequences #28

Closed cknadler closed 9 years ago

cknadler commented 11 years ago

After some thought, I think transitions to or from a sequence should result in a runtime error.

For example...

Standard transitions: (which are valid)

1:1 / 1:3
1:1 / 3
OpenG: (6:3 5,2,1:2 4,3:0)

OpenG / 1:2

Sequence transitions: (which should be invalid)

1:1 / [1:3 3:1]
[1:3 3:1] / 1:1

I'm invalidating these in the grammar for two major reasons:

russplaysguitar commented 11 years ago

Yeah, that sounds good

cknadler commented 11 years ago

This is done, tests still need to be written though.

russplaysguitar commented 11 years ago

Wrong order!

1) Tests 2) Code