Handle symbol cycles - Githubissues

cknadler / marktab-c

Concise, machine readable guitar tabs

MIT License

36 stars 7 forks source link

Closed cknadler closed 9 years ago

cknadler commented 11 years ago

An example of a symbol cycle would be:

# self reference
Sym1: [Sym1]

# reference cycle
Sym2: [Sym3]
Sym3: [Sym2]

russplaysguitar commented 11 years ago

Ya that's no good

cknadler commented 11 years ago

There is actually an easy solution for this.

Build a graph of all of the symbols in the symbol table
- Every symbol has a pointer to each symbol it contains
Implement an algorithm to find cycles in that graph
- If any exist, output the symbols involved in the cycle and bail out

russplaysguitar commented 11 years ago

Sounds good!