search

ckolderup / postmarks

a single-user bookmarking website designed to live on the Fediverse
https://postmarks.glitch.me
MIT License
456 stars 38 forks source link

Migrate bookmarks.db to application.db #137

Open johnholdun opened 9 months ago

johnholdun commented 9 months ago

Depends on #136

This is step three in a multi-step process to migrate all application data and configuration into one database, as described in #6 by @ckolderup.

Encode the tables from bookmarks.db as schemas in application.db using its migration functionality. Make the setup process detect an existing bookmarks.db file and copy all data over from it to the new tables in application.db. Update the code to read from application.db for this data. Notify the owner on startup that they can remove bookmarks.db.

jeffsikes commented 9 months ago

Discussion point on bookmarks.db. Postmarks is already pulling down the opengraph title and description. Could the og:image reference url added to the database as well? I know most apps pull down the images locally, but it doesn't have to be that way, right? You could serve the images from the original source url.

This would allow us to generate a full card to display locally on the Postmark site for each bookmark.

ckolderup commented 9 months ago

ah, interesting. I have an issue for "commonly embeddable content" (#17) as an opt-in thing-- I think there's a certain portion of the audience for "spiritual successor to del.icio.us" that wants as lofi a presentation as possible. It might make sense for visual consistency to, with that option turned on, display all non-embeddable content as a generic "opengraph card". In that case, yeah, it doesn't hurt us to add that field to what we collect.

I'm not sure if I've written this down anywhere[^1] but I'm generally trying to avoid hosting actual image data, especially incoming from UGC, because I know that's a big part of the CSAM problem that Mastodon & co have to wrestle with. As much as we can combine lofi indiweb aesthetic with avoiding giant abuse and legal headaches, I think everyone will be happier.

[^1]: or where I currently would-- I guess potentially once there's a CONTRIBUTING.md I could link to a wiki page with philosophical judgment calls like this