search

ckolderup / postmarks

a single-user bookmarking website designed to live on the Fediverse
https://postmarks.glitch.me
MIT License
466 stars 38 forks source link

Duplicate detection? #15

Open ckolderup opened 1 year ago

ckolderup commented 1 year ago

Do we want to allow multiple copies of the same URL to be bookmarked? Should we allow it but display some kind of warning/message in the UI?

andypiper commented 1 year ago

I was about to log an issue to say that we should disallow duplicates, on the basis that I'd easily forget whether I'd already added something to my DB over time; what are the use cases for allowing multiple copies?

ckolderup commented 1 year ago

I think in an earlier version of the project I was thinking of things more in terms of a linkblog, where the ActivityPub Note object was more of a first-class object rather than an interoperable broadcasting channel. In that case allowing the same URL with different title/description makes more sense (to me, at least). I do think I've come to see the platform as just being the next generation in the del.icio.us lineage, though? So maybe it does make sense to set a hard line on uniqueness.

jeffsikes commented 1 year ago

I was about to log a similar issue. I lean toward disallowing a new entry as well. Maybe allow boosting/reposting in ActivityPub tho? So the detail page on Postmarks would show a collection of posts you've made related to the link, kind of like a timeline.

Also...brainstorming here but I've been thinking about the social aspect of sharing bookmarks with other Postmarks users - if two people both share the same link (and you follow each other), showing their posts about it on your detail page of the same entry would be interesting. Might spark some conversations.

And finally...imagine a timeline of your fellow Postmarks friends. If you bookmark one of their posts, it should create a Postmarks bookmark in your collection, not just a placeholder that references that AP message! Maybe with a "bookmarked from" attribute?

andypiper commented 1 year ago

Love the ideas here, and the idea of bookmarking others' posts -> a full local bookmark.

ckolderup commented 1 year ago

I was about to log a similar issue. I lean toward disallowing a new entry as well. Maybe allow boosting/reposting in ActivityPub tho? So the detail page on Postmarks would show a collection of posts you've made related to the link, kind of like a timeline.

Also...brainstorming here but I've been thinking about the social aspect of sharing bookmarks with other Postmarks users - if two people both share the same link (and you follow each other), showing their posts about it on your detail page of the same entry would be interesting. Might spark some conversations.

Hmm, I feel like there's some trouble with combining these two ideas-- if we disallow saving the same URL twice on your own Postmarks instance, but consider other peoples' shares of URLs to be canonical bookmark objects in your Postmarks instance, what should we do if a Mastodon user you follow on Postmarks links to the same URL twice? (I would do this on Mastodon to promote a blog post to different timezones, for example, or even just to re-link to a cool website a long time after first linking to it when it has new content)

And finally...imagine a timeline of your fellow Postmarks friends. If you bookmark one of their posts, it should create a Postmarks bookmark in your collection, not just a placeholder that references that AP message! Maybe with a "bookmarked from" attribute?

This is actually in the Network page right now, albeit in a very broken form-- the "Quickadd" link at the bottom of each item opens the new bookmark page with the form auto-filled with the URL (and opengraph content similar to how the bookmarklet popup form works) as well as appending an attribution in the description field.

It needs a lot of love, as does most of the Network page-- it has the same problem as the main page itself, which is that it's noticing URLs in tags, meaning any time a post mentions another user it's showing up in the feed incorrectly, and the Quickadd button uses the first URL it finds in the post... we'd need some UX to determine which link you were trying to save. But I definitely intend to get this working.

As for the other idea above:

if two people both share the same link (and you follow each other), showing their posts about it on your detail page of the same entry would be interesting

this is interesting, and technically possible right now, though it feels like it's going to require some actual UX thinking on the logged-in bookmark detail page which is already pretty messy with all its abuse controls and whatnot. But I definitely think we should!