ckolderup / postmarks

a single-user bookmarking website designed to live on the Fediverse
https://postmarks.glitch.me
MIT License
459 stars 38 forks source link

find and eliminate hardcoded actor URL assumptions #77

Open ckolderup opened 10 months ago

ckolderup commented 10 months ago

when I was first working on this project there were some things I didn't really understand re: how actors are identified by the URL returned by webfinger, etc. In my desire from an ease-of-use standpoint to support @username@domain formats + get Mastodon crossposting working as quickly as possible, I over-relied on the double-at format and also some hardcoded URLs that are specific to Mastodon's implementation details.

I need to look through the code and find where those assumptions are baked in and start making use of webfinger + the various linked JSON resources to normalize all of that, both to fix some random interop bugs and also just to get rid of some really gnarly regexes in the codebase 🙈

This may require a migration to re-format the actors as they're stored in SQLite, which would also mean this is blocked by #37