search

ckolivas / lrzip

Long Range Zip
http://lrzip.kolivas.org
GNU General Public License v2.0
618 stars 76 forks source link

fix build failed on macos #204

Closed leleliu008 closed 2 months ago

leleliu008 commented 3 years ago

close #203

pete4abw commented 3 years ago

Generally, people who package lrzip would tailor its settings. The changes you suggest are not appropriate for a wide audience. I would make this a local change for your fork.

leleliu008 commented 3 years ago

the macOS user can't build lrzip 0.641 successfully. https://github.com/Homebrew/homebrew-core/pull/71422 HomeBrew still using lrzip 0.631 due to this problem. https://github.com/Homebrew/homebrew-core/blob/master/Formula/lrzip.rb

pete4abw commented 3 years ago

Just do ./configure --disable-asm. Removing @echo will break things. I have resolved other homebrew issues although I don't know anything about that build system. Your patch will not solve your issue. --disable-asm will.

leleliu008 commented 3 years ago

I'm not just removing @echo but replacing @echo with printf , you should see Files changed. this patch have been tested on my local mac, It can be successfully built.

pete4abw commented 3 years ago

Glad it works for you. Certain shells do not support all echo commands. /usr/bin/echo should work as advertised. I don't think I will adopt it. Better solution is to not have to kludge it at all. But automake assembly support does not support pure asm files. That is where I will put my effort. Removing the SUBDIRS could affect how make dist operates.