ckolivas / lrzip

Long Range Zip
http://lrzip.kolivas.org
GNU General Public License v2.0
618 stars 76 forks source link

Code Cleanup: remove function rzip.c: rzip_control_free() #218

Closed pete4abw closed 2 years ago

pete4abw commented 2 years ago

This function is only used in the deprecated library. It can be removed as well as the definition in rzip.h.

$ git diff
diff --git a/rzip.c b/rzip.c
index a7068b8..ba7998b 100644
--- a/rzip.c
+++ b/rzip.c
@@ -1254,17 +1254,3 @@ retry:
        clear_sslist(st);
        dealloc(st);
 }
-
-void rzip_control_free(rzip_control *control)
-{
-       if (!control)
-               return;
-
-       dealloc(control->tmpdir);
-       dealloc(control->outname);
-       dealloc(control->outdir);
-       if (control->suffix && control->suffix[0])
-               dealloc(control->suffix);
-
-       dealloc(control);
-}
diff --git a/rzip.h b/rzip.h
index 3f75ea9..e3b0129 100644
--- a/rzip.h
+++ b/rzip.h
@@ -22,6 +22,5 @@
 #include "lrzip_private.h"

 void rzip_fd(rzip_control *control, int fd_in, int fd_out);
-void rzip_control_free(rzip_control *control);

 #endif
ckolivas commented 2 years ago

Applied in cleanup thanks.