search

ckoopmann / set-protocol-v2

Set Protocol V2
0 stars 0 forks source link

NotionalTradeModule potentially incompatible with "non-mintable" fCash types #5

Open ckoopmann opened 2 years ago

ckoopmann commented 2 years ago

Link: https://github.com/code-423n4/2022-06-notional-coop-findings/issues/87 Proposed Mitigation: Change logic in _isUnderlying so that we always return from asset for non-mintable fCash types.

ckoopmann commented 2 years ago

Probably won't need to fix this since it will be done on the notional side