Closed ckormanyos closed 3 weeks ago
Issues
0 New issues
261 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
7.3% Duplication on New Code
Hi @S-Streulicht I simplified and standardized the library builds. Also put PNG config as static and not dynamic. So this is frozen in. I temporyarily removed the runtime sanitizer builds, but I will restore these soon.
As a final step, I will add PNG hash tests to CI on multi-platform.
So this thing is looking good. Your work (which wa sinspirational) is on the books.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
[![Impacted file tree graph](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132/graphs/tree.svg?width=650&height=150&src=pr&token=FVIE627J2D&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos)](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos) ```diff @@ Coverage Diff @@ ## main #132 +/- ## ======================================= Coverage 100.0% 100.0% ======================================= Files 8 8 Lines 172 171 -1 Branches 9 9 ======================================= - Hits 172 171 -1 ``` | [Files](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos) | Coverage Δ | | |---|---|---| | [mandelbrot/mandelbrot.h](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?src=pr&el=tree&filepath=mandelbrot%2Fmandelbrot.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos#diff-bWFuZGVsYnJvdC9tYW5kZWxicm90Lmg=) | `100.0% <100.0%> (ø)` | | | [mandelbrot/mandelbrot\_color.h](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?src=pr&el=tree&filepath=mandelbrot%2Fmandelbrot_color.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos#diff-bWFuZGVsYnJvdC9tYW5kZWxicm90X2NvbG9yLmg=) | `100.0% <ø> (ø)` | | | [mandelbrot/mandelbrot\_generator\_trivial.h](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?src=pr&el=tree&filepath=mandelbrot%2Fmandelbrot_generator_trivial.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos#diff-bWFuZGVsYnJvdC9tYW5kZWxicm90X2dlbmVyYXRvcl90cml2aWFsLmg=) | `100.0% <ø> (ø)` | | | [mandelbrot/mandelbrot\_text\_output.h](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?src=pr&el=tree&filepath=mandelbrot%2Fmandelbrot_text_output.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos#diff-bWFuZGVsYnJvdC9tYW5kZWxicm90X3RleHRfb3V0cHV0Lmg=) | `100.0% <ø> (ø)` | | | [test/test\_mandelbrot.cpp](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?src=pr&el=tree&filepath=test%2Ftest_mandelbrot.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos#diff-dGVzdC90ZXN0X21hbmRlbGJyb3QuY3Bw) | `100.0% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ckormanyos/mandelbrot/pull/132?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christopher+Kormanyos) > `Δ = absolute