search

ckoven / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
0 stars 0 forks source link

Updates to burnt_frac site level area weighted diagnsotics #11

Closed rgknox closed 3 years ago

ckoven commented 3 years ago

@rgknox sorry its taken me a while to get back to this. I think I actually don't want to merge this, because I want the units of currentSite%frac_burnt(currentPatch%age_class) to be in m2 burned area per m2 of site area, rather than in m2 burned area per m2 of patch area in this age class. That way we can also use the sum of currentSite%frac_burnt(:) to be our record of total site-level burned area. If I merge your changes then that is no longer true. Do you agree?

ckoven commented 3 years ago

Her @rgknox -- just wanted to check in your thoughts on my response to your PR here. I think I'm nearing the point of opening a PR on this code, and wanted to resolve this first. Thanks!

ckoven commented 3 years ago

closing this. i deleted the whole site%frac_burnt because, now that the other errors have been fixed, this isn't a very big difference anymore (<1%), and anyway, your point about making the history variables more local is really the right way to handle this and other related issues.