ckoven / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
0 stars 0 forks source link

Remove `n_luh_states` from EDInitMod.F90? #16

Closed glemieux closed 1 year ago

glemieux commented 1 year ago

Since we have hlm_num_luh2_states, can we remove the block that counts up the number of states into the (as yet) unused variable n_luh_states found in init_patches?

https://github.com/ckoven/fates/blob/44696201f9dd9a3add7889f805d39ef82b7205ff/main/EDInitMod.F90#L594-L612

ckoven commented 1 year ago

The intention was for n_luh_states to be the number of nonzero states, but since we aren't using it yet we can just remove it entirely. All we should need from this block is the call to get the state_vector

glemieux commented 1 year ago

Roger that. So the intent is to create new patches downstream of that code with areas for the specific land use type based on the state_vector values, correct?

https://github.com/ckoven/fates/blob/44696201f9dd9a3add7889f805d39ef82b7205ff/main/EDInitMod.F90#L642-L644

ckoven commented 1 year ago

right.