search

ckrack / fbootstrapp

HTML, CSS, and JS toolkit for facebook apps
http://ckrack.github.com/fbootstrapp/
Apache License 2.0
1.61k stars 173 forks source link

Twipsy breaks when using latest jQuery (Uncaught TypeError: Cannot read property 'webkit' of undefined) #25

Open fraktalfabrik opened 11 years ago

fraktalfabrik commented 11 years ago

This took me forever to find!

This will work fine:

<!DOCTYPE html>
<head>
<title>Test me</title>
<script src="http://code.jquery.com/jquery-1.7.min.js&quot;&gt;&lt;/script&gt;
<script src="/assets/fbootstrap/js/bootstrap-twipsy.js"></script>
</head><body></body></html>

Where as this will not:

<!DOCTYPE html>
<head>
<title>Test me</title>
<script src="http://code.jquery.com/jquery-latest.js&quot;&gt;&lt;/script&gt;
<script src="/assets/fbootstrap/js/bootstrap-twipsy.js"></script>
</head><body></body></html>

It throws: "Uncaught TypeError: Cannot read property 'webkit' of undefined" in Chrome & FF.

chriskarimi commented 11 years ago

This is because $.browser is deprecated in jQuery 1.9+

vikas-github commented 11 years ago

so whats the solution here?

chriskarimi commented 11 years ago

The jQuery.browser() method has been deprecated since jQuery 1.3 and is removed in 1.9. If needed, it is available as part of the jQuery Migrate plugin. We recommend using feature detection with a library such as Modernizr.

My solution was to downgrade jQuery to 1.8.3 or any compatible version for that matter.

magic890 commented 11 years ago

No updates or fix for Bootstrap?

wnghdcjfe commented 10 years ago

use jquery1.8.3

zhoupeihuang commented 9 years ago

thankyou @wnghdcjfe