search

ckruse / CFPropertyList

Read, write and manipulate both binary and XML property lists as defined by apple
MIT License
213 stars 47 forks source link

libxml-ruby doesn't build on jRuby #14

Closed dcolebatch closed 12 years ago

dcolebatch commented 12 years ago

Hey Christian,

Have you thought about using nokogiri for your XML work instead of dealing with the libxml-ruby gem? If you were willing to switch, your gem would then install on jRuby too :)

Regards, David

ckruse commented 12 years ago

Nice idea. A fallback from libxml-ruby to nokogiri to rexml would solve all dependency issues, wouldn't it?

dcolebatch commented 12 years ago

Ah yeah, that would solve it!

ckruse commented 12 years ago

Ok, I implemented and pushed these changes. Can you test them, please? Although unit tests work, a real live test would be nice :)

dcolebatch commented 12 years ago

Hi Christian,

Sure thing! You don't have a .gemspec you could chuck in the repo do you?

Rgds, David

On 27 March 2012 19:31, Christian Kruse < reply@reply.github.com

wrote:

Ok, I implemented and pushed these changes. Can you test them, please? Although unit tests work, a real live test would be nice :)

Reply to this email directly or view it on GitHub: https://github.com/ckruse/CFPropertyList/issues/14#issuecomment-4741248

David Colebatch subData

t: @dcolebatch http://twitter.com/dcolebatch e: david@subdata.com p: +1 647-478-9696 m: +61 413 455 551 (Australia) m: +1 416 822 2252 (Canada)

Without Prejudice and Under Reserve - This electronic mail message, including any and all attachments are intended only for the person(s) or entity(ies) named in the addressee field. This message contains information that is privileged and confidential.This notice serves as marking as CONFIDENTIAL information of the sender.Any dissemination or copying of this message by anyone other than the addressee is strictly prohibited. If you are not the addressee thereof or the person responsible for its delivery, please notify the sender immediately by reply email and permanently delete all copies of this message.

ckruse commented 12 years ago

I'm sorry that it took so lang to answer, I'm right busy right now…

I don't have a .gemspec file right now, but I've got a rake task. Just do a rake gem to create a gem file.

One additional note: since it is not possible to specify an optional dependency, there is no dep right now which basically means fallback to rexml if neither nokogiri nor libxml are installed

ckruse commented 12 years ago

Fallback to nokogiri and rexml works. Thanks :)

dcolebatch commented 12 years ago

No, thank you Christian!!