Closed glarizza closed 11 years ago
Just a couple of comments:
I'm open for discussion!
Hm, there seems to be a bug in rbCFTypes.rb… I have to have a closer look at it.
about the DATA_RAW: this flag only determines, what the incoming data is. If you create a new CFData segment with Base64 input, you have to specify DATA_BASE64, otherwise specify DATA_RAW. It has nothing to do with the encoding, how data is encoded in plists is defined by the plist standard: base64 in XML and raw in plist.
Hehe, the test fails because your input data is corrupted ;-) Try to open it with the PList editor. I fixed it in upstream
Ok, everything seems to work. Can you confirm? I would release a new version
Pulled down and all tests pass for me! Thanks for the insight and correcting the issue!
Fine, I released a new version :-)
Previously, String#blob was being monkey patched to account for the differences between a regular String and a CFData binary data blob. This wasn't ideal as monkey patching String can cause difficulties tracking down errors.