Closed jalcine closed 4 years ago
Do you have a different example of this? It seems as if the resource is no longer available.
Do you have a different example of this? It seems as if the resource is no longer available.
Just now seeing this. https://playvicious.social/@jalcine/100512841146408725 works as well (less HTML)
I saved the linked post and will have a look later this day… thanks for getting back to me!
I don't get it. The example you linked (https://playvicious.social/@jalcine/100512841146408725) seems to work correctly? Can you elaborate where you see a problem?
Ok, I think I see what you are talking about. I think this is not about excess content but about a wrong implementation for the implied name attribute. pin13.net/mf2 does not have a name attribute in the root h-entry because there are nested microformats (see the children). There shouldn't be a name attribute at all?
Yup, my fault for the misnomer!
(Originally published at: https://v2.jacky.wtf/post/b8c88e4a-a8c8-4838-9beb-fe309ae7cc86)
Ok, this one is complicated… basically I have to either have a list of all possible p-
and e-
properties possible or I have to remember which properties we saw for a child. Both solutions are not very elegant…
Ok, this one is complicated… basically I have to either have a list of all possible
p-
ande-
properties possible or I have to remember which properties we saw for a child. Both solutions are not very elegant…
Let me know how this is going; I'm noticing it leaking into other things I'm working on. I might have an idea for a patch but I haven't had time to actually write code for it.
I‘m currently at my in-laws, so no time for programming :( will be back on monday
Am 27.06.2020 um 00:48 schrieb Jacky Alciné notifications@github.com:
Ok, this one is complicated… basically I have to either have a list of all possible p- and e- properties possible or I have to remember which properties we saw for a child. Both solutions are not very elegant…
Let me know how this is going; I'm noticing it leaking into other things I'm working on. I might have an idea for a patch but I haven't had time to actually write code for it.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.
Ok, this bug should now be fixed. I did a lot of work on spec compliance, the biggest thing still missing is parsing value class patterns.
P.S.: feel free to reopen and/or get back to me if this still fails for you!
It seems like https://github.com/ckruse/microformats2-elixir/blob/76c0193020de2d9b4cbc7a984fc1599bbb1af60e/lib/items.ex#L125-L130 is taking a greedy approach to extracting the HTML of the content. This is resulting in:
versus the output from http://pin13.net/mf2/?url=https%3A%2F%2Fplayvicious.social%2F%40jalcine%2F101683314597453680
Note the difference in the
name
field of the parenth-entry
.