Upgrading to std Futures and latest tokio

cksac / dataloader-rs

Rust implementation of Facebook's DataLoader using async-await.

Apache License 2.0

261 stars 23 forks source link

Upgrading to std Futures and latest tokio #3

Closed tyranron closed 5 years ago

tyranron commented 5 years ago

Hi, there! Thank you for this crate 🙇

I'd like to use it extensively, but is it still maintained? The latest change was made at Aug 4 2018 and master depends on tokio-core, which is deprecated long ago.

How about upgrading to the latest tokio and refactoring with std Futures which will come in the nearest 1.36 Rust release? Would you mind on my elaboration on it?

cksac commented 5 years ago

Hi, I do plan to migrate to std Future later

tyranron commented 5 years ago

@cksac would you mind if I start the work in a fork+PR and you will review/improve/merge it later when you're ready to migrate to std Future?

cksac commented 5 years ago

@tyranron that will be great :)