search

cksac / dataloader-rs

Rust implementation of Facebook's DataLoader using async-await.
Apache License 2.0
261 stars 23 forks source link

Doesn't build: the trait futures_core::stream::Stream is not implemented for ext::TimeoutStream<S> #6

Closed davidpdrsn closed 4 years ago

davidpdrsn commented 5 years ago

Not exactly sure what is wrong here, probably something with futures having changed.

/U/d/De/dataloader-rs [master@0248d52e50a2d]
$ rustup override set nightly
info: using existing install for 'nightly-x86_64-apple-darwin'
info: override toolchain for '/Users/davidpdrsn/Desktop/dataloader-rs' set to 'nightly-x86_64-apple-darwin'

  nightly-x86_64-apple-darwin unchanged - rustc 1.40.0-nightly (e413dc36a 2019-10-14)

/U/d/De/dataloader-rs [master@0248d52e50a2d]
$ cargo build
   Compiling futures-timer v0.2.1
error[E0277]: the trait bound `ext::TimeoutStream<S>: futures_core::stream::Stream` is not satisfied
   --> /Users/davidpdrsn/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-timer-0.2.1/src/ext.rs:170:9
    |
170 | impl<S> TryStream for TimeoutStream<S>
    |         ^^^^^^^^^ the trait `futures_core::stream::Stream` is not implemented for `ext::TimeoutStream<S>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `futures-timer`.

To learn more, run the command again with --verbose.
cksac commented 5 years ago

I tried build using below versions without issues stable-x86_64-apple-darwin unchanged - rustc 1.38.0 (625451e37 2019-09-23) nightly-x86_64-apple-darwin unchanged - rustc 1.40.0-nightly (10a52c25c 2019-10-24)

davidpdrsn commented 5 years ago

If I update the "futures-timer" dependency to version "1.0.2" it compiles and the tests pass 🤔