ckskr commented 2 years ago

Value Proposition

As a user I want to insert the things that made me grateful today So that I can read it afterwards in my list of entries

Description

[x] A headline "Great to have you here" is shown
[x] A headline with a question is shown
[x] Three input fields for the users input are shown (label: "tbd")
[x] A submit button is displayed
[x] The input fields are required with a minimum length of 3
[x] After submitting the input is displayed in the list of entries
[x] If the minimum length is not given, a message will be shown to fill the input fiels
[x] Another headline marks the beginning of the entry list

(for developers team)

[x] Create new branch
[x] Create a form component with three required input field
[x] add a submit button to the form
[x] add event.preventDefault to the form submit
[x] Create form validation (required, min length=3)
[x] Render the text of the input fields ("things you are grateful for") to a card

L

JessicaLoers commented 2 years ago

Hi @ckskr 👋 Great first User Story. I have just a few super picky suggestions:

Description

the headline at the top of your wire frame "Great to have you here" is not mentioned in the user story. Only the existing elements should be visible in the wire frame, so please add the headline to your user story or remove it from the wire frame.

Acceptance Criteria
Submit button: Your button says "Add to my Diary", which is probably the list 😉. However, the Diary isn't mentioned anywhere else. I would suggest you to stay consistent and perhaps add Diary to the list headline.
What happen if the user send the form without the required input field? Is there a message shown?
The "things I'm grateful" for are showing as a list, but the input is probably a <textarea> - I would like to recommend you to think about the implementation.

Tasks
I'm a little bit confused about: Render the answers to a card What answers? 😬
You could add Component Testing (requested) to your tasks.
You could add Story Book (optional) to your tasks.

If you have any questions, feel free to ask.

RobertBReich commented 2 years ago

Looks good, found a typo in AC, row 7 "to fill the input fiels" +d

cheers R.