cksource-archive / samples-framework

☠☠☠ This repository is no longer used ☠☠☠
Other
0 stars 0 forks source link

We shouldn't rely on CKEDITOR #35

Closed adelura closed 9 years ago

adelura commented 9 years ago

In here we rely on CKEDITOR namespave but it won't be available all the time i.e. CKFinder samples.

oleq commented 9 years ago

You're right. This should become a vanilla DOM retrieval.

adelura commented 9 years ago

I wonder about strategy for old IE`s. Do we want to iclude extra script which will fix issues? For example lack of classList object. Do we prefer polyfill or maybe introduce some global object which will implement functionalities which we need?

var elem = document.getElementById( 'foo' );

// sf stands for samples framework
sf.classList.add( elem, 'bar' );
Reinmar commented 9 years ago

I don't think we need a polyfill now. There won't be enough JS yet to benefit from it.

adelura commented 9 years ago

Thix issue was fixed via #34. I intruduced JavaScript SF object with functionalities which will be described in #37.